Skip to content

Fix: Move foremanctl from prereqs to first step - #5099

Merged
jafiala merged 1 commit into
theforeman:masterfrom
jafiala:move-package-from-prereqs
Jul 30, 2026
Merged

Fix: Move foremanctl from prereqs to first step#5099
jafiala merged 1 commit into
theforeman:masterfrom
jafiala:move-package-from-prereqs

Conversation

@jafiala

@jafiala jafiala commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What changes are you introducing?

Remove the foremanctl package from prereqs into the first step of the procedure

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Prereqs are easy to miss, as demonstrated by engineers.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19; orcharhino 7.9)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • We do not accept PRs for Foreman older than 3.14.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

The PR preview for d111cdd is available at theforeman-foreman-documentation-preview-pr-5099.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@jafiala
jafiala marked this pull request as ready for review July 28, 2026 07:28
@jafiala jafiala removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Jul 28, 2026
Lennonka
Lennonka approved these changes Jul 28, 2026
View reviewed changes

@Lennonka Lennonka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM style wise

@jafiala jafiala added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jul 30, 2026
@jafiala
jafiala merged commit 8a3d800 into theforeman:master Jul 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lennonka Lennonka Lennonka approved these changes

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jafiala @Lennonka